Use standard boolean type as zend_bool typedef

[Girgias]

As we are now using C99 and bool is always defined in the stdbool.h header, make zend_bool a typedef of a standard boolean.

This catches some funky usages of zend_bool which I still have trouble debugging.

Things which need to be handled/fixed:

• Parser being confused about the short hand syntax [] for nested lists (fails with Fatal error: Cannot mix [] and list():
  I.e. [$a, [$b]] = array(new stdclass, array(new stdclass));
  See Zend/tests/list_001.phpt (or Zend/tests/list/list_reference_001.phpt and Zend/tests/list/list_reference_009.phpt
  Fixed by: baa2858
• JIT related failures (mostly type declarations and GC)

[Girgias]

Legit test failures in extensions:

DOM:

========DIFF========
002+ <r:root xmlns:r="urn::root"><data xmlns="urn::data">aaa</data></r:root>
002- <r:root xmlns:r="urn::root"><data xmlns="urn::data"/></r:root>
========DONE========
FAIL Bug #47849 (Non-deep import loses the namespace). [ext/dom/tests/bug47849.phpt]

Fixed in: 706d4f3

JIT build is still broken in regards to type declarations and GC:

Ensure type hints are enforced for functions invoked as callbacks. [tests/classes/type_hinting_004.phpt]
ZE2 type hinting [tests/lang/type_hints_002.phpt]
Bug #63635 (Segfault in gc_collect_cycles) [Zend/tests/bug63635.phpt]
Bug #68446 (Array constant not accepted for array parameter default) [Zend/tests/bug68446.phpt]
Testing type-hinted lambda parameter inside namespace [Zend/tests/ns_074.phpt]
Testing parameter type-hinted with default value inside namespace [Zend/tests/ns_070.phpt]
Testing parameter type-hinted (array) with default value inside namespace [Zend/tests/ns_071.phpt]
Testing parameter type-hinted with interface [Zend/tests/ns_072.phpt]
Testing type-hinted lambda parameter inside namespace [Zend/tests/ns_073.phpt]
Type errors for methods from traits should refer to using class [Zend/tests/trait_type_errors.phpt]
callable type#003 [Zend/tests/type_declarations/callable_003.phpt]
Scalar type - default via constants [Zend/tests/type_declarations/scalar_constant_defaults.phpt]
Scalar type - default via constants - error condition [Zend/tests/type_declarations/scalar_constant_defaults_error.phpt]

All of these fail with a Segmentation faults (Termsig=11) except tests/lang/type_hints_002.phpt which fails with an Illegal Instruction (Termsig=4)

Fixed in: 13909e5

[Girgias]

@dstogov can you have a look, or point me in the direction where to look, in regards to the JIT related segfaults? From what I seemed to have understood there is a NULL pointer which gets passed around when it is trying to do some type checks, Nikita had cursory look and didn't find any obvious misuse of zend_bool which could cause this.

Also the backtraces aren't that great as they look like this (this one in particular I got by using tests/lang/type_hints_002.sh gdb):

Program received signal SIGSEGV, Segmentation fault.
0x000000007fffffff in ?? ()
(gdb) bt
#0  0x000000007fffffff in ?? ()
#1  0x00000000086ce138 in ?? ()
#2  0x00007ffffb25b200 in ?? ()
#3  0x00007ffffffea2f0 in ?? ()
#4  0x00007ffffb215020 in ?? ()
#5  0x800000000002b614 in ?? ()
#6  0x00000000fb25b2e0 in ?? ()
#7  0x0000000000000000 in ?? ()

[dstogov]

@Girgias I have fixed the problem in master.

[Girgias]

Now that the segfaults are fixed I would just like an opinion on the way I deal with the error output stream, any better way comes to mind to someone?

[nikic]

@Girgias Wouldn't just converting display_errors to zend_uchar work?

[nikic]

zend_uchar would be enough here.

[Girgias]

@Girgias Wouldn't just converting display_errors to zend_uchar work?

It would, just felt weird that the error output stream is bundled with the fact that displaying errors is toggled by the same variable, but that just may be me, will change it to zend_uchar

[nikic]

Remaining test failure is unrelated. Please commit the parse_error/display_errors fixes separately from the typedef change.