Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: class constants parsing #5812

Closed
wants to merge 1 commit into from
Closed

refactor: class constants parsing #5812

wants to merge 1 commit into from

Conversation

moliata
Copy link
Contributor

@moliata moliata commented Jul 5, 2020

As part of my work on typed class constants, I wanted to make a separate pull request for unrelated changes.

These include:

  • Moving from ast->child[0]->attr to ast->attr
  • Making zend_ast_export_ex() export class constants' visibility
  • Extracting an additional zend_compile_class_const_group() function

@moliata moliata marked this pull request as ready for review July 5, 2020 15:52
@moliata
Copy link
Contributor Author

moliata commented Jul 5, 2020 •
edited

Failed CI builds (because of a timeout) are due to many force pushes I have done. A CI re-run should yield better results.

nikic
nikic reviewed Jul 6, 2020
View reviewed changes
Zend/zend_ast.c Outdated Show resolved Hide resolved
Zend/zend_compile.c Outdated Show resolved Hide resolved
@php-pulls php-pulls closed this in 4a0d690 Jul 6, 2020
@moliata moliata deleted the class_const_patch branch July 6, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moliata @nikic