Fix free of uninitialized memory in MATCH_ERROR #5841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
iluuu1994
force-pushed
the
fix-match-free-uninitialized-memory
branch
from
1227eb5
to
6085c82
Compare
|
Actually, the setting of |
nikic
reviewed
Jul 11, 2020
iluuu1994
force-pushed
the
fix-match-free-uninitialized-memory
branch
from
9bf1e53
to
da6d379
Compare
As suggested by Tyson Andre: php#5371 (comment) Also fix line number of unhandled match error
iluuu1994
force-pushed
the
fix-match-free-uninitialized-memory
branch
from
da6d379
to
3c4a712
Compare
|
LGTM, waiting for build to pass. It'd also be useful to add the test case that Nikita Popov mentioned for the live range values (e.g. opt_debug_level=0x10000 or a lower optimization level) |
TysonAndre
reviewed
Jul 11, 2020
|
Ok to merge? |
nikic
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Tyson Andre:
#5371 (comment)
Also fix line number of unhandled match error