Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup argument handling of Zend functions and methods #5847

Closed
wants to merge 4 commits into from
Closed

Cleanup argument handling of Zend functions and methods #5847

wants to merge 4 commits into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Jul 12, 2020 •
edited

  • Changed a few parameter names
  • Improved a few error messages
  • Promoted a few warnings to exceptions
  • Fixed an UNKNOWN default value

Additionally, I removed the $non_cs parameter of define(), but actually, I wasn't sure it's really the right time to do it.

kocsismate
kocsismate commented Jul 12, 2020
View reviewed changes
Zend/tests/008.phpt Outdated Show resolved Hide resolved
Zend/zend_builtin_functions.c Outdated Show resolved Hide resolved
Zend/zend_builtin_functions.c Outdated Show resolved Hide resolved
Zend/zend_closures.stub.php Show resolved Hide resolved
@kocsismate kocsismate force-pushed the argument-handling-zend branch 2 times, most recently from db5f85e to 1555411 Compare July 12, 2020 14:57
nikic
nikic reviewed Jul 21, 2020
View reviewed changes
Zend/zend_builtin_functions.c Show resolved Hide resolved
Zend/zend_builtin_functions.stub.php Outdated Show resolved Hide resolved
@php-pulls php-pulls closed this in 5770b66 Jul 21, 2020
@kocsismate kocsismate deleted the argument-handling-zend branch July 21, 2020 13:00
@kocsismate kocsismate mentioned this pull request Aug 11, 2020
Closed
@kocsismate kocsismate mentioned this pull request Sep 14, 2020
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

@cmb69 cmb69 cmb69 left review comments

@Girgias Girgias Girgias left review comments

Assignees
No one assigned
Labels
Parameter names
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kocsismate @nikic @cmb69 @Girgias