Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opcache.jit=tracing|function values, make on/yes/true synonym for tracing #5913

Closed
wants to merge 1 commit into from

Conversation

beberlei
Copy link
Contributor

@beberlei beberlei commented Jul 31, 2020

This is another step towards easier use of the JIT.

  • Allow opcache.jit=tracing setting to enable the tracing JIT with 1254 (the current default numeric value of opcache.jit.)
  • Allow opcache.jit=function setting to enable the function JIT with 1205
  • Make opcache.jit=true, yes, on or 1 a synonym for the current default tracing.

@beberlei
Copy link
Contributor Author

@dstogov I started working on attributes aswell, but realized that the string based ini settings are easy to do first as a seperate PR today, then you can already review and I can merge directly

@beberlei beberlei changed the title Add opcache.jit=trace|always values, make on/yes/true synonym for trace. Add opcache.jit=tracing|function values, make on/yes/true synonym for tracing Jul 31, 2020
@beberlei
Copy link
Contributor Author

beberlei commented Aug 3, 2020

@dstogov unless you have objections I am going to merge this in the afternoon. This covers what we talked about, attribute support is seperately in #5915 , because it requires some more discussion.

@nikic
Copy link
Member

nikic commented Aug 3, 2020

This looks good to me, but I'd suggest changing the default value of opcache.jit to tracing as well (rather than the corresponding numeric value).

@dstogov
Copy link
Member

dstogov commented Aug 3, 2020

looks fine

@beberlei
Copy link
Contributor Author

beberlei commented Aug 4, 2020

Merged in 53ef244

@beberlei beberlei closed this Aug 4, 2020
@carusogabriel carusogabriel added this to the PHP 8.0 milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants