Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parameter names in ext/hash #6156

Closed
wants to merge 4 commits into from

Conversation

kocsismate
Copy link
Member

No description provided.

ext/hash/hash.stub.php Outdated Show resolved Hide resolved
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change $hash -> $algorithm in mhash functions as well?

ext/hash/hash.stub.php Outdated Show resolved Hide resolved
ext/hash/hash.stub.php Outdated Show resolved Hide resolved
ext/hash/hash.stub.php Outdated Show resolved Hide resolved
ext/hash/hash.stub.php Outdated Show resolved Hide resolved
ext/hash/hash.stub.php Outdated Show resolved Hide resolved
ext/hash/hash.stub.php Outdated Show resolved Hide resolved
ext/openssl/openssl.stub.php Outdated Show resolved Hide resolved
ext/openssl/openssl.stub.php Outdated Show resolved Hide resolved
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@php-pulls php-pulls closed this in 9d9bcc2 Sep 24, 2020
@kocsismate kocsismate deleted the hash-names branch September 24, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants