Add seek($array, $offset, $whence)

[datibbaw]

This fixes bug 31375 .

It introduces seek($array, $offset [, $whence = SEEK_CUR) to perform a seek on an array. For example:

$a = [1, 2, 3];
seek($a, 1); // current = 2
seek($a, 1); // current = 3
seek($a, -1, SEEK_END); // current = 2

[bwoebi]

Actually you could just remove these superfluous fetches from the HashTable:

// for next(), similar code for reset()

    while (offset > 0 && zend_hash_move_forward(array) == SUCCESS) {
        --offset;
    }

[datibbaw]

@bwoebi Good point, I made that patch some time ago and didn't reevaluate the code :)

[ghost]

Can one of the admins verify this patch?

[datibbaw]

so far it's had a lukewarm reception in internals, which is why I didn't merge it yet. I'll bring it up again

[marcioAlmada]

This is useful

👍

[marcioAlmada]

I meant the SEEK_SET variation, more specifically. I don't really care for moving according to an offset. IMMO it makes more sense to make SEEK_SET the default behavior.

[Onion-Shen]

i am a foreniger , i am not understand what you say.sorry

At 2015-08-03 14:48:51, "Márcio Almada" notifications@github.com wrote:

I meant the SEEK_SET variation, more specifically. I don't really care for moving according to an offset. IMMO it makes more sense to make SEEK_SET the default behavior.

—
Reply to this email directly or view it on GitHub.

[nikic]

Relevant internals discussions:

http://markmail.org/message/sczgritz5jcccnwh
http://markmail.org/message/fkmpkd4wuzpybpb4

[krakjoe]

Since this PR is against a security fix only branch, and since it has merge conflicts, and would need to be different for a supported branch, I'm closing this PR.

I've read the internals discussions and the feature seems some what contentious, so please take this action as encouragement to open a clean PR accompanied by an RFC and fresh internals discussion, so that we may gather consensus and move forward with the feature.