Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing VirtualProtect() calls #6470

Closed
wants to merge 2 commits into from
Closed

Fix failing VirtualProtect() calls #6470

wants to merge 2 commits into from

Commits on Nov 30, 2020

  1. Fix failing VirtualProtect() calls 

    If JIT is disabled due to incompatible `zend_execute_ex`, only
`JIT_G(enabled)` is set to zero, but `JIT_G(on)` keeps its value.
However, calling `VirtualProtect()` with `NULL` fails with
`ERROR_INVALID_PARAMETER`.  Thus, we check for `JIT_G(enabled)` as
well, before (un)protecting the SHM.
    @cmb69
    cmb69 committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    a399858 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Fix failing VirtualProtect() calls 

    Whenever JIT is disabled due to incompatibilities, we also need to set
`JIT_G(on)` to zero.
    @cmb69
    cmb69 committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    ba5e52d View commit details
    Browse the repository at this point in the history