Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement general ldap controls #652

Closed
wants to merge 7 commits into from

Conversation

dev-zero
Copy link

Currently only for add/delete/modify/replace.

@ghost
Copy link

ghost commented Mar 7, 2015

Can one of the admins verify this patch?

@krakjoe
Copy link
Member

krakjoe commented Jan 3, 2017

Since there is a PR targeting a supported branch implementing the same feature set, I'm closing this PR.

Please take this as encouragement to work together with @heiglandreas to bring about a PR for a supported version of PHP.

@krakjoe krakjoe closed this Jan 3, 2017
@dev-zero
Copy link
Author

dev-zero commented Jan 3, 2017

@krakjoe: I am sorry, but I am not interested at all to work with you guys anymore, given that this PR sat here without any feedback for years and my mail concerning it got ignored (https://marc.info/?l=php-internals&m=139843308032437&w=2).
And asking me to fix a PR (your post before you edited it again) after neglecting it for years is just bold.

@krakjoe
Copy link
Member

krakjoe commented Jan 3, 2017

Bolder to just leave it open indefinitely without response or input from anyone ... I'm sorry it was that way for so long ...

I'm fully aware we don't deal with pull requests as we should, I personally intend to fix it and other people will jump on board (they already are).

I'm sorry we lost someone who took the time to implement a thing ... please reconsider ... at least try to see I'm acting with the best of intentions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants