curl: add new proxy constants #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, definitely needs ifdefs |
|
Any update? |
|
@Kimoi Do you need it? It should be really easy to add the |
|
I'm currently defining it myself in my code, that isn't ideal though. Theres an answer on SO about this with quite a few upvotes so I think it would be worth adding: http://stackoverflow.com/a/18293978 |
|
Fixed it and rebased on latest master |
|
Merged against 5.5 |
| @@ -844,6 +844,11 @@ PHP_MINIT_FUNCTION(curl) | |||
| REGISTER_CURL_CONSTANT(CURLPROXY_SOCKS4); | |||
| REGISTER_CURL_CONSTANT(CURLPROXY_SOCKS5); | |||
|
|
|||
| #if LIBCURL_VERSION_NUM >= 0x071200 /* Available since 7.18.0 */ | |||
There was a problem hiding this comment.
why does the comment say, available since 7.18 and the version-num const compares against 7.12?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Dr. Scre
Fixes #65469