New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: add new proxy constants #696

Closed
wants to merge 1 commit into
base: master
from

Conversation

5 participants
@LinusU
Copy link
Contributor

LinusU commented Jun 17, 2014

Thanks to Dr. Scre

Fixes #65469

@smalyshev

This comment has been minimized.

Copy link
Contributor

smalyshev commented Jul 7, 2014

yes, definitely needs ifdefs

@yui-konnu

This comment has been minimized.

Copy link

yui-konnu commented Jan 13, 2015

Any update?

@LinusU

This comment has been minimized.

Copy link
Contributor

LinusU commented Jan 13, 2015

@Kimoi Do you need it? It should be really easy to add the if in...

@yui-konnu

This comment has been minimized.

Copy link

yui-konnu commented Jan 14, 2015

I'm currently defining it myself in my code, that isn't ideal though.

Theres an answer on SO about this with quite a few upvotes so I think it would be worth adding: http://stackoverflow.com/a/18293978

@LinusU LinusU force-pushed the LinusU:patch-1 branch from 9983e1c to 4f6f6fa Jan 14, 2015

@LinusU

This comment has been minimized.

Copy link
Contributor

LinusU commented Jan 14, 2015

Fixed it and rebased on latest master

@jpauli

This comment has been minimized.

Copy link
Contributor

jpauli commented Feb 23, 2015

Merged against 5.5

@jpauli jpauli closed this Feb 23, 2015

@@ -844,6 +844,11 @@ PHP_MINIT_FUNCTION(curl)
REGISTER_CURL_CONSTANT(CURLPROXY_SOCKS4);
REGISTER_CURL_CONSTANT(CURLPROXY_SOCKS5);

#if LIBCURL_VERSION_NUM >= 0x071200 /* Available since 7.18.0 */

This comment has been minimized.

@staabm

staabm Feb 23, 2015

Contributor

why does the comment say, available since 7.18 and the version-num const compares against 7.12?

This comment has been minimized.

@jpauli

jpauli Feb 23, 2015

Contributor

0X12 == 18(dec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment