Use 16 instead of 15 bytes of random data in ReflectionReference->getId #7148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` ZEND_BEGIN_MODULE_GLOBALS(reflection) bool key_initialized; unsigned char key[REFLECTION_KEY_LEN]; ZEND_END_MODULE_GLOBALS(reflection) ``` This was previously also overwriting key_initialized, which didn't matter at all because C struct layout is always in order of declaration and the value of key_initialized was subsequently set to 1.
krakjoe
added a commit
that referenced
this pull request
Jun 13, 2021
* 'master' of github.com:php/php-src: Use 16 instead of 15 bytes of random data in ReflectionReference->getId (#7148) Fix test wrt. OPENSSL_CONF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously also overwriting key_initialized, which didn't matter at all (I think?)
because C struct layout is always in order of declaration and the value of
key_initialized was subsequently set to 1.
Amends 6347f0b added in php 7.4