Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves struct and functions needed to capture / restore Zend VM state intozend_fibers.c
to reduce API exposure. It was never possible to gain access to that state outside ofzend_fiber_switch_context()
(state is stored on the C stack), hence removing this from the header makes sense.The reason for not calling
zend_bailout()
immediately inzend_fiber_switch_context()
is that fiber implementations may require additional cleanup actions to be performed before bailing out. If we bailout during switch context it requires every call tozend_fiber_switch_context()
to be wrapped inzend_try
/zend_catch
to dealt with that which is not ideal. Plus there is only a single call to that function in the implementation ofFiber
that does direct forwarding of bailouts.@trowski As always: Ping 馃槈