replace custom opcode dumper with O+ dump #7227
Conversation
krakjoe
force-pushed
the
phpdbg-optimizer-dump
branch
3 times, most recently
from
8aff7ff
to
5e5eaca
Compare
krakjoe
force-pushed
the
phpdbg-optimizer-dump
branch
from
5e5eaca
to
cd8e511
Compare
|
What's a bit unfortunate here is that the opcodes will be dumped to stderr, while the rest of phpdbg output is on stdout. May be problematic for interleaved output. Maybe we should pass |
|
I'm not sure; Removing the oplog setting from phpdbg - which used to set FILE* output - seemed okay because you can redirect stderr to a file, and mostly get the same functionality. The oplog can be quite loud, and it's probably actually desirable to have the ability to redirect away from normal output. We'd have to pass a FILE* to every dumping function ... the diff for that is a bit far reaching for my liking ... ... cut ... |
Do we really want to do this ? |
I don't particularly care. If you think dumping to stderr from phpdbg is fine, then let's stick with it. |
This replaces custom opcode dumper with Optimizer API.
It also changes the default behaviour of printing oplines while stepping; we'll now only print instructions if quietness is off (quietness is by default on).
This results in the loss of the ability to send oplog to specific file, this feature must be untested and is highly likely unused - the only real use case for the oplog file was superseded by the oplog list (coverage) feature.