-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare tentative return types for Zend #7251
Conversation
d42e27f
to
c693213
Compare
c693213
to
54085eb
Compare
@@ -19,21 +19,23 @@ class myIterator implements Iterator | |||
var $a; | |||
var $count = 1; | |||
|
|||
#[ReturnTypeWillChange] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something weird is going on here, the test timed out if I made this method and rewind
void
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me.
deca466
to
3f5a536
Compare
Some tests fail when opcache is enabled:
|
This comment has been minimized.
This comment has been minimized.
Subtyping relationships established on internal classes are always going to hold (if we ignore Windows), so there is no need to explicitly track them. This fixes an assertion failure in GH-7251.
Assertion failure should be fixed by a837d35. |
9271ab2
to
22a8a08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG assuming CI happy
CI failure unrelated. |
Hi, I noticed that the community_job on CI failed after this commit. As shown in https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=18723&view=logs&j=55323bc0-ded7-5cf3-3d38-be3edc0baeb7&t=639abae4-2042-5d50-76a0-d1b638be5f29&l=107, here is the error message:
As I'm not familiar with this feature, I was wondering how to bypass this failure? |
Thanks for the report! I'm going to provide a fix for these errors today :) |
I believe you have fixed the failure for PHPUnit. As I checked the latest test result of community job, PHPUnit can pass now. But I found the similar failure occurred for "lavarel" project. See https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=18795&view=logs&j=55323bc0-ded7-5cf3-3d38-be3edc0baeb7&t=34be0e1e-9444-50b4-935f-27096e97282a&l=448 Could you help to check this? Thanks. |
No, it was Sebastian himself :) I noticed that he added the necessary suppressions yesterday (e.g. https://github.com/sebastianbergmann/phpunit/blob/master/tests/_files/SampleArrayAccess.php#L33), so I went directly to the Laravel failures: #7290 |
Thanks for the information. |
No description provided.