Fix a typo in function execute_ex #7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suppose it's a typo. The fix is trivial. Change-Id: I6c1cc12493f377be2d63f65de8e77b3a9e7db237
|
This is a generated file, the change needs to be done in zend_vm_gen.php. |
Thanks for spotting that. Will update soon. |
As pointed by nikic, "zend_vm_execute.h" is one generated file, and "zend_vm_gen.php" is the right place to update. Change-Id: I03c6439b7b1806d57efb15e6809f7c2e801fd43a
|
It's still necessary to generate the file, by running |
You mean run |
|
Yeah, that's right. |
Run "php Zend/zend_vm_gen.php", and the following three files would be generated. As only file zend_vm_execute.h is changed, we commit it as well. ``` $./sapi/cli/php Zend/zend_vm_gen.php zend_vm_opcodes.h generated successfully. zend_vm_opcodes.c generated successfully. zend_vm_execute.h generated successfully. ``` Change-Id: Ice23d375eb8482d2a75fde783d8b7bec9a8c1198
Thanks for your explanation. Updated now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose it's a typo. The fix is trivial.
Change-Id: I6c1cc12493f377be2d63f65de8e77b3a9e7db237