Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SplFileObject::fseek() method description #7321

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Fix SplFileObject::fseek() method description #7321

merged 1 commit into from
Jul 30, 2021

Conversation

andrew-demb
Copy link
Contributor

No description provided.

@kamil-tekiela
Copy link
Member

Thanks, but how about:

Sets the file position of the stream to the given offset

@andrew-demb
Copy link
Contributor Author

@kamil-tekiela thank you for the suggestion.

I copied the description from php.net (https://www.php.net/manual/en/splfileobject.fseek.php)
Should we also update docs then?

@kamil-tekiela
Copy link
Member

Ok, then I think it's fine as you suggested. The code is self-explanatory anyway

@kamil-tekiela kamil-tekiela merged commit d7b77a4 into php:master Jul 30, 2021
@andrew-demb andrew-demb deleted the patch-1 branch July 30, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrew-demb @kamil-tekiela