Add support for generating optimizer function info from stubs #7367
Conversation
kocsismate
force-pushed
the
stub-refcount
branch
from
1205621
to
769d0a9
Compare
kocsismate
force-pushed
the
stub-refcount
branch
from
19d0b56
to
cf446cb
Compare
As pointed out on GH-7367, these have not been adjusted for object constant support. Now the only thing the type info specifies is that array of ref is not possible.
kocsismate
force-pushed
the
stub-refcount
branch
4 times, most recently
from
83fc011
to
e165a3a
Compare
kocsismate
force-pushed
the
stub-refcount
branch
from
47f7429
to
9983ad1
Compare
kocsismate
force-pushed
the
stub-refcount
branch
from
36d7935
to
87d8fa4
Compare
Zend/zend_builtin_functions.stub.php
Outdated
| /** @return string|array|object|null */ | ||
| /** | ||
| * @return string|array<int, string|object>|object|null | ||
| * @refcount N |
There was a problem hiding this comment.
Similar to the @refcount 0 case, as @refcount N is the default state for non-scalar types, can we omit it and generate the func info based on presence of more specific return type?
There was a problem hiding this comment.
Can these @refcount N lines be dropped after your last change?
There was a problem hiding this comment.
Yeah, I'll do that, thanks for pointing them out! Furthermore, I could forbid the addition of @refcount 1 and @refcount N. Another question I had: what to do with functions with void and never return type? Can I disallow adding a refcount (both implicitly and explicitly) to them?
I'll rebase to master soon.
kocsismate
force-pushed
the
stub-refcount
branch
2 times, most recently
from
e66c503
to
a6ad823
Compare
kocsismate
force-pushed
the
stub-refcount
branch
from
a6ad823
to
11f862a
Compare
kocsismate
force-pushed
the
stub-refcount
branch
from
b22026b
to
9956594
Compare
…PHPDoc return type != native return type
kocsismate
force-pushed
the
stub-refcount
branch
from
9956594
to
460b202
Compare
|
Pinging @ondrejmirtes as you might be interested in the array-related PHPDoc changes :) |
|
@kocsismate Thank you, I'll look into it :) |
No description provided.