Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate &Properties; entity in xpointer for inherited properties in class synopses #7400

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

salathe
Copy link
Contributor

@salathe salathe commented Aug 25, 2021

This changes ClassInfo::createIncludeElement() such that it takes the $query argument as-is for the xpointer attribute value. Special characters, like " and &, are used as-is so be careful not to break the resulting XML.

Refs:

… synopses

This changes ClassInfo::createIncludeElement() such that it takes the $query
argument as-is for the xpointer attribute value. Special characters, like
" and &, are used as-is so be careful not to break the resulting XML.
@nikic
Copy link
Member

nikic commented Aug 25, 2021

Looks reasonable.

Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the help!

@kocsismate kocsismate merged commit 36e88a0 into php:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants