Add support for generating MAY_BE_ARRAY_OF_REF func info flag #7416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Aug 27, 2021
nikic
reviewed
Aug 30, 2021
kocsismate
force-pushed
the
stub-array-ref
branch
from
950345b
to
72d3f0c
Compare
nikic
reviewed
Aug 30, 2021
nikic
reviewed
Aug 30, 2021
nikic
reviewed
Aug 30, 2021
kocsismate
force-pushed
the
stub-array-ref
branch
from
ef31697
to
a72b327
Compare
nikic
approved these changes
Aug 30, 2021
nikic
reviewed
Aug 30, 2021
| @@ -123,7 +123,10 @@ function timezone_name_from_abbr(string $abbr, int $utcOffset = -1, int $isDST = | |||
|
|
|||
| function timezone_offset_get(DateTimeZone $object, DateTimeInterface $datetime): int {} | |||
|
|
|||
| /** @refcount 1 */ | |||
| /** | |||
| * @return array<int|string, mixed>|false | |||
There was a problem hiding this comment.
Suggested change
| * @return array<int|string, mixed>|false | |
| * @return array<int, array>|false |
There was a problem hiding this comment.
Sorry, I merged it too fast. I'll create a followup.
| @@ -713,7 +726,10 @@ function mysqli_field_tell(mysqli_result $result): int {} | |||
| function mysqli_free_result(mysqli_result $result): void {} | |||
|
|
|||
| #if defined(MYSQLI_USE_MYSQLND) | |||
| /** @refcount 1 */ | |||
| /** | |||
| * @return array<int|string, mixed> | |||
There was a problem hiding this comment.
Suggested change
| * @return array<int|string, mixed> | |
| * @return array<string, mixed> |
| @@ -469,7 +469,10 @@ function pg_get_result(PgSql\Connection $connection): PgSql\Result|false {} | |||
| /** @refcount 1 */ | |||
| function pg_result_status(PgSql\Result $result, int $mode = PGSQL_STATUS_LONG): string|int {} | |||
|
|
|||
| /** @refcount 1 */ | |||
| /** | |||
| * @return array<int|string, mixed> | |||
There was a problem hiding this comment.
Suggested change
| * @return array<int|string, mixed> | |
| * @return array<int|string, int|string> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.