[gen_stub] fix nested namespaced typed property in gen_stub.php #7418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test to the zend_test extension? |
zeriyoshi
force-pushed
the
gen_stub_fix
branch
from
ed14a63
to
e459ef7
Compare
zeriyoshi
force-pushed
the
gen_stub_fix
branch
from
e459ef7
to
ef04abf
Compare
kocsismate
reviewed
Aug 30, 2021
nikic
reviewed
Aug 31, 2021
build/gen_stub.php
Outdated
| @@ -1351,7 +1351,9 @@ public function getDeclaration(): string { | |||
| if (count($arginfoType->classTypes) >= 2) { | |||
| foreach ($arginfoType->classTypes as $classType) { | |||
| $className = $classType->name; | |||
| $code .= "\tzend_string *property_{$propertyName}_class_{$className} = zend_string_init(\"$className\", sizeof(\"$className\") - 1, 1);\n"; | |||
| $escapedClassName = str_replace('\\', '\\\\', $className); | |||
There was a problem hiding this comment.
I believe this is $classType->toEscapedName().
There was a problem hiding this comment.
Thanks.
It seems to me that there is no ClassType type and everything is SimpleType, is this intended?
If it is intended, keep it is.
There was a problem hiding this comment.
I noticed this as well, and fixed the type hint in c1c1822.
nikic
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen_stub.php fails to auto-generate typed properties with nested namespaces.
There is nothing broken in php-src with this at the moment, but we will try to fix it as it is difficult to create an extension.