Fix OOB read due to timezone_open() with 5 digit offset #7492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been reported as bug #78984, and is generally and properly fixed as of timelib 2020.3 (PHP-8.0). However, it is not fixed in PHP-7.4, where the test results in an OOB read, and an unterminated C string when calling `::getName()`. Therefore, we apply a minimal fix which just avoids this dangerous behavior.
|
There's this upstream backport: derickr/timelib@8482a89 Maybe this will get pulled in yet? |
|
@derickr, what do you think: backport derickr/timelib@8482a89, or only applay this PR for PHP-7.4? |
|
I can't really import that version of timelib, as it changes/adds some features, so the quick fix seems like a good idea. I don't expect to pull in further versions of timelib into 7.4. |
nikic
approved these changes
Sep 17, 2021
|
Applied as fac3fbc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been reported as bug #78984, and is generally and properly
fixed as of timelib 2020.3 (PHP-8.0). However, it is not fixed in
PHP-7.4, where the test results in an OOB read, and an unterminated
C string when calling
::getName(). Therefore, we apply a minimalfix which just avoids this dangerous behavior.