Fix zend_register_internal_class_ex alias generation #8091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wouldn't work for creating aliases in a namespace. It would create the class alias "MyNS_ClassName" instead of "MyNS\\ClassName"
nikic
approved these changes
Feb 14, 2022
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wouldn't work for creating aliases in a namespace.
It would create the class alias "MyNS_ClassName" instead of
"MyNS\ClassName" for
@alias MyNS\ClassNameThis was probably copied from nearby code which created a C identifier, where
_was the proper separator,but
\\is what should be used within a double quoted C string passed to zend_register_internal_class_exThis has no impact in
php build/gen_stub.php --force-regenerationfor php-src itself