Avoid accessing undefined variables in run-tests.php #8669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
May 31, 2022
run-tests.php
Outdated
Comment on lines
938
to
943
| if (!getenv('NO_INTERACTION') && !TRAVIS_CI) { | ||
| $fp = fopen("php://stdin", "r+"); | ||
| if (getenv('NO_INTERACTION') || TRAVIS_CI) { | ||
| $stdin = null; | ||
| $user_input = ''; | ||
| } | ||
| else { | ||
| $stdin = fopen("php://stdin", "r"); |
There was a problem hiding this comment.
This code path would be refactored if #8657 lands
There was a problem hiding this comment.
Bah! I tried to search for relevant open PRs, and found none. Maybe I should have stuck to the actual fix I needed, which was the $php_cgi var.
There was a problem hiding this comment.
Yeah, please remove the changes to mail sending, and leave that to the other PR; other that that, this patch looks good to me.
There was a problem hiding this comment.
Rebased, so now just has the smaller variable fixes.
The $php_cgi and $phpdbg cases here are definitely real bugs, and caused the script to bail out under certain ini settings. The other paths may actually be unreachable in practice, but were highlighted by PhpStorm.
IMSoP
force-pushed
the
run-tests-undef-vars
branch
from
339ae0f
to
5111f3e
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The $php_cgi and $phpdbg cases here are definitely real bugs, and
caused the script to bail out under certain ini settings.
The other paths may actually be unreachable in practice, but were
highlighted by PhpStorm.