Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdo_dblib ext test conflicts when run in parallel #9430

Closed

Conversation

mvorisek
Copy link
Contributor

I was checking if Oracle test issues are gone, they are, but I saw: https://github.com/php/php-src/runs/8033123653?check_suite_focus=true#step:10:1401

so fix it like #9424

Copy link
Contributor

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cmb69
Copy link
Contributor

cmb69 commented Aug 26, 2022

@mvorisek, did you notice that the CI hangs terribly while creating the Oracle container (already runs for more than 90 min). Would it be possible to add a time-out for that step?

@cmb69 cmb69 closed this in f866295 Aug 26, 2022
@mvorisek
Copy link
Contributor Author

mvorisek commented Aug 26, 2022

@mvorisek, did you notice that the CI hangs terribly while creating the Oracle container (already runs for more than 90 min). Would it be possible to add a time-out for that step?

we use gvenzl/oracle-xe images in hundreds of CI pipelines daily and it seems this was some GH Action issue, because the Docker images - https://hub.docker.com/r/gvenzl/oracle-xe/tags - were not updated and we have seen this problem today in atk4 repos too - https://github.com/atk4/ui/runs/8035477339?check_suite_focus=true

if the issue will continue, we can add some timeout or better talk with the image maintainer, in any case, let me know

UPDATE: see also https://github.com/atk4/ui/runs/8036377065?check_suite_focus=true#step:2:340, 30+minutes pull, when you compare it to the CI pipeline above, it seems the problem is in the pull phase from Docker Hub to Github Actions, not even the Docker image itself

@mvorisek mvorisek deleted the fix_pdo_dblib_parallel_conflicts branch August 26, 2022 13:23
@mvorisek
Copy link
Contributor Author

@cmb69 there is however one another issue with ext/oci8/tests/extauth_02.phpt test - https://github.com/php/php-src/runs/8046983493?check_suite_focus=true#step:13:1363

It seems the test tries to connect to some anything and d domains/resources and hang on timeout. Not exactly sure, as this test does not fail every CI run. Can you please look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants