Allow arrays with define(), to match const syntax support

[hikari-no-yume]

This fixes an oversight in PHP 5.6, where you can create constant arrays with const yet not with define(). The hope is it can go into a micro release, as it's basically just a bugfix.

[hikari-no-yume]

OK, Bob Weinand pointed out I need to ensure the array contains no references or non-scalars. Will do that.

EDIT: Done, see commit below.

[smalyshev]

I think there should be a better description here.

[hikari-no-yume]

"Arrays are now permitted as constant values."?

[hikari-no-yume]

Made a version for master as well: #954

[hikari-no-yume]

Hey @dstogov, didn't you say you'd take a look at this?

[dstogov]

Hi Andrea,

Sorry, I thought you were gong to provide a patch for master.
I think it's better not to apply this in 5.6.
Even if it won't make technical problems it'll bring incompatibility
between minor 5.6.* versions.

I made a patch for master on top of yours -
https://gist.github.com/dstogov/3956efd7bbf924cfa0f8
If you don't see any problems feel free to commit it.

Thanks. Dmitry.

On Sat, Dec 20, 2014 at 6:42 AM, Andrea Faulds notifications@github.com
wrote:

Hey @dstogov https://github.com/dstogov, didn't you say you'd take a
look at this?

—
Reply to this email directly or view it on GitHub
#951 (comment).

[hikari-no-yume]

@dstogov I already made a patch for master: #954

[hikari-no-yume]

Yours seems alright, though, I'll merge it.

[hikari-no-yume]

Merged here, closing this request: 0833fd4