Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FCI API #9723

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Refactor FCI API #9723

wants to merge 5 commits into from
+32 −133

Commits on Sep 11, 2023

  1. Do not use zend_fcall_info_argp() for ticks and shutdown functions 

    Instead handle the copying and safe reallocation of the param zvals ourself.
    @Girgias
    Girgias committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    4f6fbd9 View commit details
    Browse the repository at this point in the history

  2. Remove zend_fcall_info_call() API 

    The last parameter which is named zval *args, does NOT set the FCI params field.
It is expected to be a PHP array which gets looped over to set the arguments which is also a zval pointer...

Since PHP 8.0, the named_params field is a more appropriate way of doing this.

Also remove zend_fcall_info_args_save() and zend_fcall_info_args_restore() as they were only used in the implementation of zend_fcall_info_call()
    @Girgias
    Girgias committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    e25a5d1 View commit details
    Browse the repository at this point in the history

  3. Remove zend_fcall_info_argn() and zend_fcall_info_argv() 

    Usage of these function heap allocates the zvals when they can already be used directly with an FCI
    @Girgias
    Girgias committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    43079d5 View commit details
    Browse the repository at this point in the history

  4. Remove zend_fcall_info_argp() 

    This function reallocates the param zvals on the heap, when in general they can be directly assigned to the FCI
    @Girgias
    Girgias committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2157d2d View commit details
    Browse the repository at this point in the history

  5. [W.I.P.] Document API removals in UPGRADING.INTERNALS 

    TODO better description of what to do in each case
    @Girgias
    Girgias committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2903fa7 View commit details
    Browse the repository at this point in the history