Convert PDO Statement constructor arguments to HashTable* #9725
+52
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stepping stone for using named_params in the FCI directly
cmb69
reviewed
Oct 13, 2022
|
Discussion thread: https://externals.io/message/118847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stepping stone for using named_params in the FCI directly.
Split out of #9723 because it a rather consequential change.
One thing I'm not sure about, is that currently PDO can currently pass arguments by-reference to te constructor when the fetch mode is
FETCH_CLASS. I'm not sure if this sensible at all, but in any case this PR would break this.Is this breaking change sensible in theory, or does it really make sense for PDO to pass args by ref to the constructor?