FPM delete child log event before child is killed #9817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
fpm_stdio_event_del
branch
from
b5e8a61
to
16bc3b5
Compare
We should delete event before freeing child so it cannot be triggered after the child is freed.
bukka
force-pushed
the
fpm_stdio_event_del
branch
from
16bc3b5
to
51e9017
Compare
bukka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant like a different approach for fixing #8517 rather than #9444 but it didn't actually fix the issue. It still however makes sense to clear up those events to reduce the number of fd which might be beneficial.