Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TEST_FPM_EXTENSION_DIR for FPM tests with shared extensions #9854

Closed
wants to merge 1 commit into from

Conversation

bukka
Copy link
Member

@bukka bukka commented Oct 30, 2022

More generic solution for #9643

@bukka
Copy link
Member Author

bukka commented Oct 30, 2022

@andypost Please can you test this and let me know if that works for you?

@bukka bukka changed the base branch from master to PHP-8.0 October 30, 2022 16:40
@andypost
Copy link
Contributor

Thanks, will do tomorrow

@andypost
Copy link
Contributor

Works for me even for php 8.0 (it has 2 arguments for method), thank you!

/mnt/testing/php8 $ TEST_FPM_EXTENSION_DIR=modules TESTS='--show-diff sapi/fpm/tests/bug77780-header-sent-error.phpt' abuild check

Build complete.
Don't forget to run 'make test'.


=====================================================================
PHP         : /mnt/testing/php8/src/php-8.0.25/sapi/cli/php 
PHP_SAPI    : cli
PHP_VERSION : 8.0.25
ZEND_VERSION: 4.0.25
PHP_OS      : Linux - Linux andy-HP 5.19.0-23-generic #24-Ubuntu SMP PREEMPT_DYNAMIC Fri Oct 14 15:39:57 UTC 2022 x86_64
INI actual  : /mnt/testing/php8/src/php-8.0.25/tmp-php.ini
More .INIs  :   
---------------------------------------------------------------------
PHP         : /mnt/testing/php8/src/php-8.0.25/sapi/phpdbg/phpdbg 
PHP_SAPI    : phpdbg
PHP_VERSION : 8.0.25
ZEND_VERSION: 4.0.25
PHP_OS      : Linux - Linux andy-HP 5.19.0-23-generic #24-Ubuntu SMP PREEMPT_DYNAMIC Fri Oct 14 15:39:57 UTC 2022 x86_64
INI actual  : /mnt/testing/php8/src/php-8.0.25/tmp-php.ini
More .INIs  : 
---------------------------------------------------------------------
CWD         : /mnt/testing/php8/src/php-8.0.25
Extra dirs  : 
VALGRIND    : Not used
=====================================================================
Running selected tests.
PASS FPM: bug77780 - Headers already sent error incorrectly emitted [sapi/fpm/tests/bug77780-header-sent-error.phpt] 
=====================================================================
Number of tests :    1                 1
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :    1 (100.0%) (100.0%)
---------------------------------------------------------------------
Time taken      :    1 seconds
=====================================================================
NOTE: We have skipped quite a lot tests, see disabled-tests.list.

@andypost
Copy link
Contributor

andypost commented Nov 5, 2022

@bukka what's left here to get it merged?

@andypost
Copy link
Contributor

needs rebase

@bukka
Copy link
Member Author

bukka commented Nov 13, 2022

Sorry for the delay. Merged to PHP-8.0+ via db2d32f

@bukka bukka closed this Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants