Prevent users from adding multiple votes on a single bug

[jacobbednarz]

Fixes #51535 by implementing a single bug ID and IP check prior to inserting a users vote.

[bjori]

Shouldn't it rather overwrite the previous vote?
Otherwise we'll get mail that they accidentally voted x but wanted to vote y?

This isn't particularly high impact feature though, its mostly to avoid users commenting "me too"

[jacobbednarz]

Shouldn't it rather overwrite the previous vote?
Otherwise we'll get mail that they accidentally voted x but wanted to vote y?

It hadn't thought of that - humans are clumsy and I could see this being an issue. I'm happy to have it update the record if you feel that it would better close this bug report off?

[jacobbednarz]

Updated to allow duplicate votes to update instead of ignoring.

[bjori]

Is there no "UPDATE .... ON NOT EXISTS INSERT INTO ..." (upsert) mechanism in MySQL?
Its weird you need to query/count first and then decide to update a record or insert it.

If not, then this is fine with me

[php-pulls]

There is: http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html
Not sure about our unique indexes.
2015.01.05. 19:19 ezt írta ("Hannes Magnusson" notifications@github.com):

Is there no "UPDATE .... ON NOT EXISTS INSERT INTO ..." (upsert) mechanism
in MySQL?
Its weird you need to query/count first and then decide to update a record
or insert it.

If not, then this is fine with me

—
Reply to this email directly or view it on GitHub
#13 (comment).

[bjori]

Right, thats the other way around -
INSERT or UPDATE if it did exists. We want
UPDATE if it exists or INSERT if it does not

we cannot add unique index on this at this point as I'm sure there are plenty dupes already.

[bjori]

you have karma to merge it yourself now