Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event submission form error: "missing some parameters" #999

Closed
bbloom opened this issue Jun 2, 2024 · 4 comments · Fixed by #1017
Closed

Event submission form error: "missing some parameters" #999

bbloom opened this issue Jun 2, 2024 · 4 comments · Fixed by #1017

Comments

@bbloom
Copy link

bbloom commented Jun 2, 2024

Hello everyone. My name is Bob Bloom.

I am lead organizer of GTA PHP (Greater Toronto Area PHP), York Region PHP, and Laravel Toronto. In lieu of an actual website, I post stuff at https://github.com/local-toronto-php-groups. Our meetup.com links are there. If you are in Toronto this upcoming Thursday, join us at the heart of Toronto's financial district, at a fantastic corporate host. Larry Garfield is joining us remotely to talk about Property Hooks, new to PHP 8.4.

Thank you to the PHP team for making Groups high visibility on PHP.net. I know there are too many monthly user group events to list on the home page. However, IMO, the link to a calendar of events is even better.

Unfortunately, I am not able to contribute my Groups' events to this calendar. The reason is that I am get the "missing some parameters error".

image

There could be something very obvious that I am overlooking, and as a Canadian, let me say that I am sorry to trouble you about this.

I did try contacting people via email whom I thought might be associated with PHP.net, or could recommend to me whom to contact. I was ultimately successful, and appreciative of the thoughtful reply. So I am here posting this issue as a result.

Also, while I am here, is there a list of Groups on PHP.net? Something like what Go has at https://go.dev/wiki/GoUserGroups? My thinking is that Toronto area PHP devs would go to PHP.net, so our group, and then click to our GitHub organization.

Thank you for your help, it is much appreciated.

Regards from Toronto!
-Bob Bloom

@iansltx
Copy link
Contributor

iansltx commented Jun 19, 2024

Tangentially related: @bbloom are you aware of https://php.ug/ ? That's the closest thing to a user group list that PHP has to my knowledge.

@sy-records
Copy link
Member

Maybe because of it?
image

@tiffany-taylor
Copy link
Member

I am able to reproduce the issue locally. I selected the correct option of "Yes" and the issue occurs. I'm thinking there's an issue with https://github.com/php/web-master/blob/main/public/entry/event.php but I'll need to spend more time troubleshooting/diagnosing.

@bbloom
Copy link
Author

bbloom commented Jun 20, 2024 via email

iansltx added a commit to iansltx/web-php that referenced this issue Jun 22, 2024
Resolves php#999

At some point in the past 12 years (this line was modified in the last 3 years
but I doubt it got tested when modified) main.php.net started redirecting
insecure HTTP to HTTPS, including for POSTs. The catch with those redirects is
that POSTs won't get resubmitted when redirected, so when submitting an event
the redirect would result in a GET with no parameters to the event submission
endpoint, hence "Missing parameters." So event submission has been broken since
main.php.net started redirecting HTTP to HTTPS.

Back in 2012 there was an attempt to switch this and other URLs to HTTPS, but
it got rolled back because "there could be mirrors without ssl support." (see
blame for the line this commit modifies). Since then, mirrors have been phased
out, so we can safely assume we're calling HTTPS endpoints now (and that's the
only way this will work anyway).

Verified by hitting the mentioned endpoint both on HTTP and HTTPS. HTTP gets
redirected and fails due to missing parameters, HTTPS makes it through to the
next step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants