Merge pull request #167 from michbeck/master

Fix for generic tag description properly parsing 0
phpDocumentor · Apr 30, 2019 · 4835166 · 4835166
2 parents 90ae750 + 6907dec
commit 4835166
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/DocBlock/Tags/Generic.php b/src/DocBlock/Tags/Generic.php
@@ -53,7 +53,7 @@ public static function create(
         Assert::stringNotEmpty($name);
         Assert::notNull($descriptionFactory);
 
-        $description = $descriptionFactory && $body ? $descriptionFactory->create($body, $context) : null;
+        $description = $descriptionFactory && $body !== "" ? $descriptionFactory->create($body, $context) : null;
 
         return new static($name, $description);
     }

diff --git a/tests/integration/DocblocksWithAnnotationsTest.php b/tests/integration/DocblocksWithAnnotationsTest.php
@@ -44,4 +44,18 @@ public function testDocblockWithAnnotations(): void
 
         $this->assertCount(3, $docblock->getTags());
     }
+
+    public function testDocblockWithAnnotationHavingZeroValue(): void
+    {
+        $docComment = <<<DOCCOMMENT
+            /**
+     * @my-tag 0
+     */
+DOCCOMMENT;
+
+        $factory = DocBlockFactory::createInstance();
+        $docblock = $factory->create($docComment);
+
+        $this->assertSame(0, printf('%i', $docblock->getTagsByName('my-tag')));
+    }
 }