Added test for regression on invalid types #364
Merged
+204
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@williamdes I added some more tests in this pr and a small fix that will catch issues when types are not valid. The tests are easy to extend so if you want to make sure we cover some extra situations please do create a pr. I think after testing this a lot, that I cannot find any regressions or breaking changes. So we should be quite good to go now. |
|
Thank you for your hard work, I will update Doctum soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an more extensive test suite for invalid and valid types covered by this library. This does not cover all types supported by the type-resolver but it helps to cover the most common cases.