-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make class directive work for simple cases #221
Conversation
e734c83
to
f702f23
Compare
When the changes from #21 are merged (I believe Jaap started working based on my commits there), this should be relatively easy by looping over the node tree and applying class nodes to the next node. |
The compiler is already there. So this can be done with a new compiler pass. |
I would suggest adding a none rendered node that represents the class in the node tree. This will help us to do some compiling after the parser is ready. Let's suggest that we have a Then we could implement a new
I did not test this and the code may contain issues, but I think it could be something like this. If you need more complex logic I would recommend you have a look at the |
class directives applied to neighboring nodes post-phoned for now
f702f23
to
40bb503
Compare
Appart from the question about the reset of classes, this is great! thanks for this contribution |
Move tests to integration tests as NodeTransformers are not applied in the functional tests
526a659
to
23243b0
Compare
Cool to have this feature in. Thanks! |
class directives applied to neighboring nodes post-phoned for now