-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref role resolving #233
Ref role resolving #233
Conversation
@linawolf I would like to have your opinion on the subparser. I think we do not need it anymore as we have a different way of doing this using the Right now And for example, the includes do not work as they should, as we should literally include the nodes of the included file. So title levels are kept the same when a document is included. |
Thanks for continuing my work! I'll likely try these changes out in the Symfony docs and do a review on Thursday |
I am honestly still getting used to the new architecture by fixing some tiny things. Not far enough in to have an oppinion, really |
Not sure if it's 100% related to this one, but when rendering the Symfony docs on this branch (rebased on #252) there are some invalidly detected references. Examples:
Other than this, it seems to work flawless on the Symfony docs! :) |
I think this are bugs in the span parser. I need to have a look. But not related to this pr. |
Using the ref role, you can create a hyperlink to an explicit internal link target (anchor nodes).
The text role `ref` is now supported as it should. Simplyfied the way links are rendered without markup in the titles. This allows us again to create links using just text. There is a major issue with using the subparsers in this change the sub documents are isolated from the main document. This causes issues handling includes. We should refactor this in another effort.
Internal target is part of the metas, as it is build from the documents, and overlapping for the full set.
During a refactoring the document links were broken, the alternative text was ignored.
f05941a
to
f36e915
Compare
The text role
ref
is now supported as it should.Simplyfied the way links are rendered without markup in the titles.
This allows us again to create links using just text.
There is a major issue with using the subparsers in this change
the sub documents are isolated from the main document. This causes
issues handling includes. We should refactor this in another effort.