make sure substr picks the correct length

phpDocumentor · Jun 23, 2017 · 04dbcf4 · 04dbcf4
1 parent 6705115
commit 04dbcf4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/phpDocumentor/Transformer/Router/StandardRouter.php b/src/phpDocumentor/Transformer/Router/StandardRouter.php
@@ -88,7 +88,7 @@ public function configure()
         // if this is a link to an external page; return that URL
         $this[] = new Rule(
             function ($node) {
-                return is_string($node) && (substr($node, 0, 7) == 'http://' || substr($node, 0, 7) == 'https://');
+                return is_string($node) && (substr($node, 0, 7) == 'http://' || substr($node, 0, 8) == 'https://');
             },
             function ($node) { return $node; }
         );

diff --git a/tests/unit/phpDocumentor/Transformer/Router/StandardRouterTest.php b/tests/unit/phpDocumentor/Transformer/Router/StandardRouterTest.php
@@ -65,6 +65,7 @@ public function testIfARouteForAFileCanBeGenerated($descriptorName, $generatorNa
 
     /**
      * @covers phpDocumentor\Transformer\Router\StandardRouter::configure
+     * @covers phpDocumentor\Transformer\Router\StandardRouter::__construct
      * @covers phpDocumentor\Transformer\Router\RouterAbstract::__construct
      * @covers phpDocumentor\Transformer\Router\RouterAbstract::configure
      * @covers phpDocumentor\Transformer\Router\RouterAbstract::match