Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: list all supported config file file names and precedence #2451

Open
jrfnl opened this issue Jun 17, 2020 · 0 comments
Open

Documentation: list all supported config file file names and precedence #2451

jrfnl opened this issue Jun 17, 2020 · 0 comments

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Jun 17, 2020

Related to / follow-up to #1997

I'm a little confused about the default supported configuration file names.
Based on the current documentation for v3, these would be phpdoc.dist.xml and phpdoc.xml.

The first one of these, to me, is surprising, as other "tooling" applications in the PHP sphere, like PHPUnit and PHPCS, use the reverse order for the file extension, so I would expect phpdoc.xml.dist.

Reversing the extensions based on what they are used to from other tools, would be a typical and easy mistake for people to make and I imagine it would be helpful not to receive support requests for this situation.

If I understood issue #1997 correctly, the filename phpdoc.xml.dist is now supported in phpDocumentor 3 ?

Based on that, I believe:

  • The fact that this is now supported should be mentioned in the changelog.
  • The documentation needs to be updated to include the third supported file name.
  • The documentation would need to make a clear statement about the precedence of the file names.

In issue #1997 I did see a mention that the file precedence / file loading order needs to be determined, but I couldn't find a decision on how the precedence/ fileorder has been implemented.

To me, the logical order would be as follows, but I haven't tested whether this is the reality or not:

  • phpdoc.xml
  • phpdoc.dist.xml
  • phpdoc.xml.dist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
phpDoc issue triage board
  
Needs triage
Development

No branches or pull requests

2 participants