Composer And Travis Updates #1400
Conversation
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
|
|
|||
| <phpunit bootstrap="tests/common/bootstrap.php" colors="true" strict="true"> | |||
| <phpunit bootstrap="tests/common/bootstrap.php" colors="true"> | |||
There was a problem hiding this comment.
Same comments as in PR https://github.com/phpDocumentor/GraphViz/pull/11/files#r16568057 apply; I can only merge this if disabling strict does not cause the @covers tag (and hence code coverage) to suddenly mark all executed code as covered, instead of that which we indicate is covered
There was a problem hiding this comment.
I don't believe it alters how @covers marks code lines in the code coverage report. I made this change in my own builds with the v4 upgrade, until such time as I can tighten up the cover annotations. As best I can tell, strict just decides if the passing test is considered a "very good pass" vs a "sloppy pass".
|
I've just rebased this. Is it good to merge? |
|
Currently running the unit tests to generate code coverage before this change, then I will apply this change locally and rerun code coverage to determine the effect of removing strict |
|
It all worked out perfectly! Thanks for this contribution! |
No description provided.