[WIP]: Initial effort to replace Cilex with Symfony4 #1940
Conversation
mvriel
changed the title
mvriel
force-pushed
the
replace-cilex-with-sf4
branch
3 times, most recently
from
ff0695d
to
af08976
Compare
There was a problem hiding this comment.
Some things to remember, but nothing to be changed right now. Of course this pr is still work in progress.
In my pr where I introduce the v3 config I also started to remove the calls to $output and replace them by events. One of the issues I still have to face is how the logger should be configured. I see that you are also replacing that. So it might be wise to have a chat about that.
Main reason for me to remove the calls to $output is that I'm moving the logic in commands to pipeline stages that are reused in the commands. E.g. Run command uses the pipeline of parse and transform commands.
| @@ -0,0 +1,42 @@ | |||
| #!/usr/bin/env php | |||
There was a problem hiding this comment.
Think this file should be named phpdoc?
| @@ -0,0 +1 @@ | |||
| ../vendor/nikic/php-parser/bin/php-parse | |||
There was a problem hiding this comment.
I think all other files in bin should be ignored.
mvriel
force-pushed
the
replace-cilex-with-sf4
branch
from
014d7ba
to
03be59d
Compare
mvriel
force-pushed
the
replace-cilex-with-sf4
branch
from
03be59d
to
4631b1e
Compare
In this change I have replaced Cilex with Symfony 4. In this change I have introduced a compatibility layer so that third-party's can integrate with minimal effort. An important thing to note is that this layer should be temporary and there is not a 100% guarantue. For one; order now matters and this may cause errors for some third-parties.
mvriel
force-pushed
the
replace-cilex-with-sf4
branch
from
4631b1e
to
9ddbfb3
Compare
|
closed by #1932 |
In this change I have replaced Cilex with Symfony 4. The basic idea behind this change is that it would be easier to build the application on a complete framework, and the bundles could work as a plugin system instead of our hand-rolled one.
As it stands, Symfony 4 is light weight enough to work as a microframework for all intents and purposes.
This change is not complete and merge-able, the following things need to be done:
When this is done we can subsequently begin migrating the services from our own Service Providers