Fix loading V3 config from default locations #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some tests to show the need for these changes. And to be sure that we won't break this behavior in the future. |
|
Done |
ptomulik
force-pushed
the
fix-version3-config
branch
from
84bfb44
to
584c6eb
Compare
|
Hi, I wrote a simple test. Anything else I should do? |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A V3 config file containing errors is currently silently ignored, and either a default configuration is used or a next (possibly V2) file if exists. This seems to be quite counter-intuitive. An existing config file should rather be reported to contain errors, if it is the case. This PR provides a fix for this.