experiment with getTypes #2289
Closed
experiment with getTypes #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, best I could do is use the same trick as in TypedAbstract and array_filter the getType result to be sure not to return null. |
|
This will close #2248 |
|
This should be good to merge too if you think it's worth it. The CI fail is not related |
|
I don't get it, build fails spectacularly but there's almost nothing on this PR. It didn't seem to affect other PR though... |
|
I think we need to update our ci setup. But due to different priorities I didn't get to that yet. No worries as soon as I have fixed the ci I will notify you. |
|
Please rebase, let's see if we can merge this one :-) |
|
I really don't get it. I'm starting to think there's something wrong with this specific PR... Other PR pass without issue... |
|
replaced by #2315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.