Leverage newer API of PrettyVersion #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
reviewed
Jan 29, 2021
There was a problem hiding this comment.
Thanks for your PR, it is really appreciated that you took the time to help us improve phpDocumentor!
It would be nice if you could answer my question about the supported versions. From there I can take this PR over and fix the missing parts regarding our code style :-D Unless you have time to do it yourself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With those changes, you'll stop leveraging the transient dependency of
ocramius/package-versionand use the dedicated API of PrettyVersion. This also allows PrettyVersion 2.0 which drops the sub dependency alltogether, and hooks into the Composer 2 APIs directly.