Images were not embedded when generating guides #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Images are copied over when the Asset filter is used in a twig template. Although you could debate whether it should not be a reference and copied over in a single pass, the issue arose that the destination file system with the wrong path was provided as source for the image location. This is incorrect, but it also showed that there is room for improvement in how we deal with paths in guides. This is not addressed in this PR, but merely that the origin filesystem is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images are copied over when the Asset filter is used in a twig template.
Although you could debate whether it should not be a reference and
copied over in a single pass, the issue arose that the destination file
system with the wrong path was provided as source for the image
location.
This is incorrect, but it also showed that there is room for improvement
in how we deal with paths in guides. This is not addressed in this PR,
but merely that the origin filesystem is passed