Do not show container section of TOC in classes #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes have a method getInterfaces() with which you describe which interfaces a Class implements, but this conflicts in the table-of-contents template as this assumes that if there is a getInterfaces() method it will show a section intended for namespaces, packages and files. This change introduces twig test functions to test for various types of descriptors, and an extra check in the table of contents template whether the given node is an element container.
…tainer-elements-in-toc-for-classes
mvriel
deleted the
fix/do-not-show-container-elements-in-toc-for-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes have a method getInterfaces() with which you describe which interfaces a Class implements, but this conflicts in the table-of-contents template as this assumes that if there is a getInterfaces() method it will show a section intended for namespaces, packages and files.
This change introduces twig test functions to test for various types of descriptors, and an extra check in the table of contents template whether the given node is an element container.