feat: preserve newlines in XML attributes #3430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to test this via https://twigfiddle.com/s65ia4 and with my local checkout of
phpdoc
.Essentially, this ensures that newlines are preserved in the XML attributes for
structure.xml
. Otherwise, the newline characters are lost.Eg:
When usng
SimpleXMLElement
, this will be rendered without any newlines. E.g.{ Optional. Data for populating the Message object. @type string $name supply a name for this object}
.By using the
replace
filter in twig, the result will instead be: