Remove file and index getters and setters from project #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably the most lowhanging fruit because files and indexes are not set using the main setter, but mostly by getting the collection and adding onto that.
mvriel
commented
Mar 19, 2023
| ); | ||
| foreach ($project->getVersions() as $version) { | ||
| $apiSets = $version->getDocumentationSets()->filter(ApiSetDescriptor::class); | ||
| foreach ($apiSets as $apiSet) { |
There was a problem hiding this comment.
Just to clarify, using multiple documentation sets would still not work because it is not fully supported when it comes to linking and even writing to the correct folder; but this will ensure the documentation set is propagated throughout the chain, which allowed me to remove findElement from the Project
jaapio
reviewed
Mar 19, 2023
jaapio
approved these changes
Mar 20, 2023
jaapio
deleted the
remove-file-and-index-getters-and-setters-from-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, I have begun the effort of moving stuff out of the ProjectDescriptor that doesn't belong there into the DocumentationSetDescriptors. This also means Project references might be deleted from some services in favour of this one.
This doesn't yet replace the getFiles and getIndexes calls because these are used in a lot of files and warrants a separate PR