feat: add magic flag to xml template #3520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added support for magic methods added to the Class template recently, but in the generated
structure.xml
, there's no way to tell if they've been inherited, or if they're magic methods.Summary of changes:
inherited_from
for magic methodsmethod.class
does not matchclass
. This may not be the best way, but it seemed like the approach with the least churnmagic="true"
attribute to the<method>
tag (e.g.<method /* ... */ magic="true">
)@method
tag, that's already possible, so I'm 100% okay getting rid of this.I'd love some feedback here!!
Note:
magic
is probably the wrong label to use for methods added with__call
, because according to the PHP Documentation, PHP magic methods are methods prefixed with__
. The methods added with__call
are referred to as "overloaded methods", which I also don't like, as that represents something different in other OO languages such as Java.