Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add basic extension loading #3567

Merged
merged 8 commits into from Aug 27, 2023
Merged

Feat: Add basic extension loading #3567

merged 8 commits into from Aug 27, 2023

Conversation

jaapio
Copy link
Member

@jaapio jaapio commented Aug 20, 2023

Enable loading of phpdoc extensions. Extensions are based on symfony DI extensions. We do check the manifest.xml for compatibility to ensure we have everything needed.

@jaapio
Copy link
Member Author

jaapio commented Aug 20, 2023

This is a follow up PR of #3041. I removed all logic of symfony/framework-bundle that makes it less complex to load extensions as we do not have to take care of the container cache.

@jaapio jaapio force-pushed the feature/extensions branch 2 times, most recently from 6e7143c to 691e1c1 Compare August 20, 2023 20:50
Enable loading of phpdoc extensions. Extensions are based on symfony
DI extensions. We do check the manifest.xml for compatibility to ensure
we have everything needed.
Metadata processing allows extensions to add there own data to the
descriptors, which can be used during rendering.
Via the commandline it is now possible to set the extensions directory
this directory will be used to load extensions.
The phar release is using an authoritative classmap, this blocks
us from loading extensions. The new fallback autoloader is
used to load extensions.
@jaapio jaapio force-pushed the feature/extensions branch 2 times, most recently from b9a8934 to 855404b Compare August 27, 2023 12:47
@jaapio jaapio marked this pull request as ready for review August 27, 2023 13:12
@jaapio jaapio mentioned this pull request Aug 27, 2023
4 tasks
@jaapio jaapio merged commit c0dd6b1 into master Aug 27, 2023
47 of 48 checks passed
@jaapio jaapio deleted the feature/extensions branch August 27, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant