Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong value for visibility option in XSD #3666

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

sebastian-meyer
Copy link
Contributor

The phpDocumentor command line helper says, that the parameter visibility allows the following values:

api, public, protected, private, internal.

But the configuration XSD enumerates the following values as valid options:

api, public, protected, private, hidden.

So internal is missing from the XSD and using hidden actually leads to an error.

This pull requests fixes this issue by replacing hidden with internal in the XSD.

(I already opened a pull request for this issue [#3663], but that was marked as "merged" although is wasn't.)

@sebastian-meyer
Copy link
Contributor Author

The failing QA workflow reports an issue with a part of code this pull request doesn't change. Am I supposed to fix this anyway with this PR?

@jaapio
Copy link
Member

jaapio commented Feb 10, 2024

It's ok, I will take care of psalm. If you want to fix it feel free to open a pr. That would be very helpful.

Thanks for addressing this!

@jaapio jaapio merged commit 9045ca3 into phpDocumentor:master Feb 10, 2024
32 of 34 checks passed
@sebastian-meyer sebastian-meyer deleted the fix-xsd branch February 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants