Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Psalm issue #3672

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

sebastian-meyer
Copy link
Contributor

Currently Psalm reports the following issue on master:

Error: src/phpDocumentor/Descriptor/Traits/ImplementsInterfaces.php:52:56: LessSpecificImplementedReturnType: The inherited return type 'phpDocumentor\Descriptor\Collection<phpDocumentor\Descriptor\Interfaces\InterfaceInterface|phpDocumentor\Reflection\Fqsen>' for phpDocumentor\Descriptor\Interfaces\ClassInterface::getInterfacesIncludingInherited is more specific than the implemented return type for phpDocumentor\Descriptor\Traits\ImplementsInterfaces::getinterfacesincludinginherited 'phpDocumentor\Descriptor\Collection' (see https://psalm.dev/166)

This PR should fix this by declaring a more specific return type for this method.

@jaapio
Copy link
Member

jaapio commented Feb 15, 2024

Thanks!

@jaapio jaapio merged commit 1873822 into phpDocumentor:master Feb 15, 2024
34 checks passed
@sebastian-meyer sebastian-meyer deleted the fix-psalm-issue branch February 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants